Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix persistent store unit testing #321

Closed
wants to merge 2 commits into from
Closed

Fix persistent store unit testing #321

wants to merge 2 commits into from

Conversation

jmichelp
Copy link
Collaborator

@jmichelp jmichelp commented Jun 9, 2021

Fixes #320

@google-cla google-cla bot added the cla: yes label Jun 9, 2021
@jmichelp jmichelp requested a review from ia0 June 9, 2021 11:12
@ia0
Copy link
Member

ia0 commented Jun 9, 2021

Looks like NoneError was removed recently: rust-lang/rust#85614. This fix will only postpone the issue until we update our compiler. I'll take a look how to fix this with the new try_trait_v2 (or just work-around if not possible).

@kaczmarczyck kaczmarczyck mentioned this pull request Jun 9, 2021
Closed
@jmichelp
Copy link
Collaborator Author

jmichelp commented Jun 9, 2021

Dropping this PR (workaround) in favor of #322 (proper fix)

@jmichelp jmichelp closed this Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaczmarczyck kaczmarczyck kaczmarczyck approved these changes

@ia0 ia0 Awaiting requested review from ia0

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing the persistent store library in github workflows now fails
3 participants
@jmichelp @ia0 @kaczmarczyck