-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove patch #67
Remove patch #67
Conversation
There's something weird happening on my desktop. My guess is that because my build folder is longer than on Travis, the binary is bigger. Indeed, due to Rust including debug paths in binaries, the longer the folder, the larger the binary.
This means that I reach the limit of 128K currently set in the layout.ld, but not Travis and GitHub workflows (yet). We should be able to increase the limit to 192K (the On Travis:
For me the
Edit: on GitHub workflow with a long directory name:
|
Sounds good to me to use 192K. Also note that we don't use 0x30000-0x40000. So we could also push that limit if needed. |
That's good to know. Although I don't expect reaching the next limit soon. We could also tune the board configuration to remove all the drivers that we don't use, which would definitely free up some space but also be one more patch to maintain. |
I also tested the app on the nRF52840-DK. Works.
|
Removed the path rules in the new workflow, to keep this pull-request focused on removing the patch. I don't think the |
1664: Generalize chip_layout.ld to Nordic boards and increase ROM size on nrf52840. r=ppannuto a=gendx ### Pull Request Overview This pull request increases the `rom` size on nrf52840-based boards to fill up the space available before apps. This makes it consistent with the nRF52-DK (which has more `rom` available despite fewer flash space overall). Files are also re-organized so that nRF52840-DK and nRF52840-Dongle share the same chip layout file. Note that the previous limit of 128KB was just exceeded in google/OpenSK#67. There are more drivers in that case (persistent storage and USB), but it's simpler to keep the limit higher in Tock than to have to maintain a separate patch for OpenSK. ### Testing Strategy This pull request was tested by: - compiling all boards with `make ci-travis`, - flashing an nRF52840-DK with OpenSK. ### TODO or Help Wanted N/A ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make formatall`. Co-authored-by: Guillaume Endignoux <guillaumee@google.com>
Fixes #58. This synchronizes with upstream Tock to remove the patch added in #60.