Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducible builds #70

Closed
gendx opened this issue Mar 6, 2020 · 2 comments · Fixed by #78 or #94
Closed

Reproducible builds #70

gendx opened this issue Mar 6, 2020 · 2 comments · Fixed by #78 or #94
Labels
enhancement New feature or request

Comments

@gendx
Copy link
Collaborator

gendx commented Mar 6, 2020

As mentioned in tock/tock#1666, binaries built with Rust are not reproducible by default. One main reason is panic messages that embed an absolute path to the file containing them (so building with --panic-console isn't reproducible by default).

We should apply the same techniques as in tock/tock#1666 to make OpenSK builds reproducible.

This would avoid issues like spurious linker errors when using a long build path, as discovered in #67.

@gendx gendx added the enhancement New feature or request label Mar 6, 2020
@jmichelp jmichelp mentioned this issue Mar 11, 2020
2 tasks
@gendx
Copy link
Collaborator Author

gendx commented Mar 12, 2020

Re-opening to remember to update the kernel once tock/tock#1668 is merged upstream.

It could also be worth displaying a hash of the binaries like in tock/tock#1669.

@gendx
Copy link
Collaborator Author

gendx commented Mar 13, 2020

As mentioned in #80 (comment), the crypto material is generated for each build (as intended). We could have a workflow that uses fixed material to test for reproducibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant