-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export typing information #923
base: master
Are you sure you want to change the base?
Conversation
This commit adds the flag that the package contains typing information. Therefore other packages can use the typing data to check their code by mypy. Ref.: https://mypy.readthedocs.io/en/stable/installed_packages.html#making-pep-561-compatible-packages Signed-off-by: Jan Luca Naumann <j.naumann@fu-berlin.de>
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for the PR! I'll fix the build and merge this. |
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 129 129
Lines 22394 22394
=======================================
Hits 21957 21957
Misses 437 437
Continue to review full report at Codecov.
|
This commit adds the flag that the package contains typing
information. Therefore other packages can use the typing data to check their
code by mypy.
Ref.: https://mypy.readthedocs.io/en/stable/installed_packages.html#making-pep-561-compatible-packages
Signed-off-by: Jan Luca Naumann j.naumann@fu-berlin.de