Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

[WebGPU article] Check adapter before using it #9198

Merged
merged 2 commits into from Jan 13, 2021
Merged

[WebGPU article] Check adapter before using it #9198

merged 2 commits into from Jan 13, 2021

Conversation

beaufortfrancois
Copy link
Member

@beaufortfrancois beaufortfrancois commented Jan 12, 2021

This PR makes sure adapter is valid before using. I've also updated all Glitch samples.
Context: https://chromium-review.googlesource.com/c/chromium/src/+/2617499

@Kangz for review

Live preview: https://pr-9198-dot-web-central.appspot.com/web/updates/2019/08/get-started-with-gpu-compute-on-the-web

@google-cla google-cla bot added the cla: yes label Jan 12, 2021
@WebFundBot
Copy link

Whoops!

There were 3 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

WARNINGS
src/content/en/updates/2019/08/get-started-with-gpu-compute-on-the-web.md#L73 - Common typo found: 'implicity' Should it be 'implicitly'?
src/content/en/updates/2019/08/get-started-with-gpu-compute-on-the-web.md#L231 - Common typo found: 'implicity' Should it be 'implicitly'?
src/content/en/updates/2019/08/get-started-with-gpu-compute-on-the-web.md#L238 - Line must be at most 100 characters

@beaufortfrancois
Copy link
Member Author

@petele Please merge and push live.

@petele petele merged commit 2ba31d5 into master Jan 13, 2021
@petele petele deleted the gpu-adapter branch January 13, 2021 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants