Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups #24

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Minor cleanups #24

merged 2 commits into from
Mar 23, 2023

Conversation

qwandor
Copy link
Collaborator

@qwandor qwandor commented Mar 22, 2023

Use self rather than &self on Descriptor methods as it is Copy, and merge the two MemoryRegion implementation blocks.

@qwandor
Use self rather than &self for all methods on Descriptor.
bcfc045 
It is Copy, so there's no point taking a reference, and the other
methods don't either so it's inconsistent.
@qwandor
A single implementation of MemoryRegion is enough.
25e6044 
Splitting it into two implementations in the same file just makes it
harder to find.
@qwandor qwandor merged commit 1ade791 into main Mar 23, 2023
@qwandor qwandor deleted the cleanup branch March 23, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardbiesheuvel ardbiesheuvel ardbiesheuvel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qwandor @ardbiesheuvel