Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups #24

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Minor cleanups #24

merged 2 commits into from
Mar 23, 2023

Commits on Mar 23, 2023

  1. Use self rather than &self for all methods on Descriptor. 

    It is Copy, so there's no point taking a reference, and the other
methods don't either so it's inconsistent.
    @qwandor
    qwandor committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    bcfc045 View commit details
    Browse the repository at this point in the history

  2. A single implementation of MemoryRegion is enough. 

    Splitting it into two implementations in the same file just makes it
harder to find.
    @qwandor
    qwandor committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    25e6044 View commit details
    Browse the repository at this point in the history