Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Navigation] Overlapping elements in Sample Bottom Sheets layout #972

Closed
leinardi opened this issue Jan 26, 2022 · 5 comments · Fixed by #1148
Closed

[Navigation] Overlapping elements in Sample Bottom Sheets layout #972

leinardi opened this issue Jan 26, 2022 · 5 comments · Fixed by #1148
Assignees
@jossiwolf
Labels
stale Stale issues which are marked for closure

Comments

@leinardi
Copy link
Contributor

Description
It seems that something is off with the layout of the Navigation: Bottom Sheets of the Sample app: the button to show a new bottom sheet is overlapping the arg text showing the UUID.
Steps to reproduce
Run the sample on an emulator (tested on API 23 and 31)
Expected behavior
All the elements (button and text) should be visible and not overlapping
Additional context
image image
@jossiwolf jossiwolf assigned jossiwolf and unassigned jbw0033 Jan 27, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Feb 27, 2022
@jossiwolf jossiwolf removed the stale Stale issues which are marked for closure label Feb 28, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Mar 31, 2022
@jossiwolf jossiwolf removed the stale Stale issues which are marked for closure label Mar 31, 2022
@github-actions
Copy link

github-actions bot commented May 1, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label May 1, 2022
leinardi added a commit to leinardi/accompanist that referenced this issue May 1, 2022
@leinardi
Fix overlapping elements in Sample Bottom Sheets layout
677a159 
Closes google#972
@leinardi leinardi mentioned this issue May 1, 2022
Merged
@leinardi
Copy link
Contributor Author

leinardi commented May 1, 2022

@jossiwolf I made a PR with a fix.

@github-actions github-actions bot removed the stale Stale issues which are marked for closure label May 2, 2022
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Jun 1, 2022
@github-actions github-actions bot closed this as completed Jun 7, 2022
leinardi added a commit to leinardi/accompanist that referenced this issue Jul 10, 2022
@leinardi
Fix overlapping elements in Sample Bottom Sheets layout
f31aebd 
Closes google#972
@bentrengrove bentrengrove reopened this Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jossiwolf jossiwolf

Labels
stale Stale issues which are marked for closure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Navigation] Fix overlapping elements in Sample Bottom Sheets layout leinardi/accompanist
4 participants
@bentrengrove @leinardi @jossiwolf @jbw0033