Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose 1.2.0-beta03 #1186

Merged
merged 3 commits into from Jun 3, 2022
Merged

Compose 1.2.0-beta03 #1186

merged 3 commits into from Jun 3, 2022

Conversation

bentrengrove
Copy link
Collaborator

@bentrengrove bentrengrove commented Jun 1, 2022

Fixed an issue in navigation material. It was setting hide called back to false too soon, removing the set fixes the issue. The flag is set back to false thanks to the remember being keyed with the backStackEntry

@bentrengrove bentrengrove force-pushed the ben/update-beta03 branch 4 times, most recently from a0fc305 to 2912773 Compare Jun 1, 2022
Copy link
Collaborator

@jossiwolf jossiwolf left a comment

Thank you, Ben!

} finally {
hideCalled = false
}
sheetState.internalHide()
Copy link
Collaborator

@jossiwolf jossiwolf Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly not the ideal solution but if it works I can come back to it next week :)

@bentrengrove bentrengrove changed the title Prepare for next release Compose 1.2.0-beta03 Jun 3, 2022
@bentrengrove bentrengrove merged commit 06c937d into main Jun 3, 2022
2 checks passed
@bentrengrove bentrengrove deleted the ben/update-beta03 branch Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants