Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ANR when showing bottom sheets #680

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Fix ANR when showing bottom sheets #680

merged 2 commits into from
Aug 26, 2021

Commits on Aug 25, 2021

  1. Fix ANR when showing bottom sheets 

    Our `internalShow` method could end up in an infinite loop sometimes (yay, recursion!). We now use the official `show` API which *should* work. Unfortunately, our `show` calls all get cancelled but Swipeable still settles in the closest state. This seems to always be the expanded/half-expanded state. We look at the state's targetValue in our try's `finally` block to figure out if the state will settle in an expanded state and call the `onSheetShown` callback based on that.

Fixes google#660
    @jossiwolf
    jossiwolf committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    3c6b2d7 View commit details
    Browse the repository at this point in the history

  2. Literal code polish, it should be spotless now :p

    @jossiwolf
    jossiwolf committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    aa659c1 View commit details
    Browse the repository at this point in the history