-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Navigation Material] Update Docs and Sample to use new API for adding custom Navigators #746
[Navigation Material] Update Docs and Sample to use new API for adding custom Navigators #746
Conversation
Navigation 2.4.0-alpha10 is out now so I think you can update the dependency now. |
Will do, thanks for the heads up! The snapshot was failing to resolve a dependency |
59325c2
to
fb58bfe
Compare
fb58bfe
to
520d2ad
Compare
The one test that failed was a Pager test, there shouldn't be any connection. |
if (savedState != null) navController.restoreState(savedState) | ||
navigator = remember(navController) { BottomSheetNavigator(sheetState) } | ||
navController.navigatorProvider += navigator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this line anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏
To be merged once Nav 2.4.0 Alpha 10 is released :)
Fixes #744