Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Navigation] Integrate new rememberNavController APIs for custom Navigators #744

Closed
ianhanniballake opened this issue Sep 28, 2021 · 0 comments · Fixed by #745 or #746
Closed

[Navigation] Integrate new rememberNavController APIs for custom Navigators #744

ianhanniballake opened this issue Sep 28, 2021 · 0 comments · Fixed by #745 or #746
Labels
enhancement New feature or request

Comments

@ianhanniballake
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Navigation is adding an API for adding custom Navigators by extending the rememberNavController() API in the upcoming Navigation 2.4.0-alpha10 release.

Describe the solution you'd like
It would be nice if rememberAnimatedNavController() had those same APIs and the Navigation Material had its samples, documentation, and tests updated to use it / the new rememberNavController().

Describe alternatives you've considered
This is just a convenience API, so you can do it manually, but keeping the API surfaces in sync between Navigation itself and Navigation Animation is super useful.
@ianhanniballake ianhanniballake added the enhancement New feature or request label Sep 28, 2021
jossiwolf added a commit to jossiwolf/accompanist that referenced this issue Sep 29, 2021
@jossiwolf
Add ability to pass custom animators to rememberAnimatedNavController
16d15f9 
Fixes google#744
jossiwolf added a commit to jossiwolf/accompanist that referenced this issue Sep 29, 2021
@jossiwolf
Update Docs and Sample to use new API for adding custom Navigators
59325c2 
Fixes google#744
This was referenced Sep 29, 2021
Merged
Merged
jossiwolf added a commit to jossiwolf/accompanist that referenced this issue Sep 29, 2021
@jossiwolf
Add ability to pass custom animators to rememberAnimatedNavController
4e26ecb 
Fixes google#744
jossiwolf added a commit to jossiwolf/accompanist that referenced this issue Sep 29, 2021
@jossiwolf
Update Docs and Sample to use new API for adding custom Navigators
fb58bfe 
Fixes google#744
jossiwolf added a commit to jossiwolf/accompanist that referenced this issue Sep 29, 2021
@jossiwolf
Add ability to pass custom animators to rememberAnimatedNavController
09f4c14 
Fixes google#744
jossiwolf added a commit to jossiwolf/accompanist that referenced this issue Sep 29, 2021
@jossiwolf
Update Docs and Sample to use new API for adding custom Navigators
520d2ad 
Fixes google#744
jossiwolf added a commit to jossiwolf/accompanist that referenced this issue Sep 29, 2021
@jossiwolf
Add ability to pass custom animators to rememberAnimatedNavController
ff4c2af 
Fixes google#744
chrisbanes pushed a commit that referenced this issue Sep 30, 2021
@jossiwolf
[Navigation Material] Update Docs and Sample to use new API for addin…
a285f41 
…g custom Navigators (#746)

* Update Navigation to 2.4.0-alpha10

* Update Docs and Sample to use new API for adding custom Navigators

Fixes #744

* Remove unneeded add statement
chrisbanes pushed a commit that referenced this issue Sep 30, 2021
@jossiwolf
[Navigation Animation] Add ability to pass custom animators to rememb…
eb91aff 
…erAnimatedNavController (#745)

* Update Navigation to 2.4.0-alpha10

* Add ability to pass custom animators to rememberAnimatedNavController

Fixes #744

* Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@ianhanniballake