This repository has been archived by the owner on Feb 9, 2023. It is now read-only.
Expose tts volume and pitch to the user code like we do with lang. #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drigz
suggested changes
Nov 27, 2017
src/aiy/audio.py
Outdated
| """ | ||
| global _tts_volume |
There was a problem hiding this comment.
Remove - these aren't required in this function, as it uses get_*_volume.
There was a problem hiding this comment.
Yeah sorry about that. Didn't do much python programming yet.
src/aiy/_drivers/_tts.py
Outdated
| @@ -20,6 +20,7 @@ | |||
| import subprocess | |||
| import tempfile | |||
| from aiy import i18n | |||
| from aiy import audio | |||
There was a problem hiding this comment.
Remove - this creates a circular import between the two modules, which could lead to confusing problems later.
src/aiy/_drivers/_tts.py
Outdated
| return functools.partial(say, player, lang=lang) | ||
| volume = audio.get_tts_volume() | ||
| pitch = audio.get_tts_pitch() | ||
| return functools.partial(say, player, lang=lang, volume=volume, pitch=pitch) |
There was a problem hiding this comment.
I'd suggest ignoring volume and pitch here and letting say() handle it.
|
Merged - works like a charm! Thank you for contributing. |
|
No problem. This benefits me too :). |
drigz
added a commit
to drigz/aiyprojects-raspbian
that referenced
this pull request
Dec 21, 2017
Summary of changes: - Fix instructions for using the Voice Kit on Stretch (google#187) - Make it easier to turn the LED off (google#167) - Fix crash with trigger sound (google#163) - Let user code control TTS (google#185) - Enable hotwording with Cloud Speech (0b4972b)
This was referenced Dec 28, 2017
drigz
added a commit
to drigz/aiyprojects-raspbian
that referenced
this pull request
Jan 3, 2018
Summary of changes: - Fix instructions for using the Voice Kit on Stretch (google#187) - Make it easier to turn the LED off (google#167) - Fix crash with trigger sound (google#163) - Let user code control TTS (google#185) - Enable hotwording with Cloud Speech (0b4972b) Change-Id: Icfad0fadeaeb63417413c598763eceddb5bd0b9c
drigz
added a commit
to drigz/aiyprojects-raspbian
that referenced
this pull request
Jan 3, 2018
Summary of changes: - Fix instructions for using the Voice Kit on Stretch (google#187) - Make it easier to turn the LED off (google#167) - Fix crash with trigger sound (google#163) - Let user code control TTS (google#185) - Enable hotwording with Cloud Speech (0b4972b) - Update to Cloud Speech v1 (google#206)
drigz
added a commit
to drigz/aiyprojects-raspbian
that referenced
this pull request
Jan 3, 2018
Summary of changes: - Fix instructions for using the Voice Kit on Stretch (google#187) - Make it easier to turn the LED off (google#167) - Fix crash with trigger sound (google#163) - Let user code control TTS (google#185) - Enable hotwording with Cloud Speech (0b4972b)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the title says, this will expose the volume and pitch for tts to the user code.
It can be set/get globally with:
Or set individually with say: