Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review database failure model design+implementation (exceptions, failure mode, transaction) #510

Closed
fredhersch opened this issue May 28, 2021 · 1 comment · Fixed by #599
Closed

Review database failure model design+implementation (exceptions, failure mode, transaction) #510

fredhersch opened this issue May 28, 2021 · 1 comment · Fixed by #599
Assignees
@deepankarb @jingtang10
Labels
type:enhancement New feature or request
Projects
FHIR engine library
Milestone
Q2 June 2021

Comments

@fredhersch
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Current implementation needs to be reviewed. Related to this discussion #482 (comment)

Describe the solution you'd like

  • Review current design and implementation
  • Review existing thread
  • Make any necessary outstanding changes
  • Identify any additional requirements and prioritise on roadmap
@fredhersch fredhersch added this to To do in FHIR engine library via automation May 28, 2021
@fredhersch fredhersch mentioned this issue May 28, 2021
Closed
8 tasks
@Tarun-Bhardwaj Tarun-Bhardwaj added this to the Q2 June 2021 milestone Jun 4, 2021
@deepankarb
Copy link
Contributor

Inputs from some senior devs @ Google:

DatabaseImpl.kt LGTM. That being said I'm not a Room expert, but DatabaseImpl doesn't seem to be doing anything esoteric. The one question I have is how are the indexes handled.

FhirSynchronizer.kt LGTM too. The only thing that pops up is that It downloads resource types sequentially (line47) , which could potentially be done concurrently, but if not in any critical path it's perfectly fine that way.

Opened #574 for second item.

deepankarb added a commit that referenced this issue Jun 28, 2021
@deepankarb
Cleanup DB exceptions, fixes #510
278a7c7 
* Removed unused exceptions
* Refactored ResourceNotFoundException and removed redundant copy
@deepankarb deepankarb mentioned this issue Jun 28, 2021
Merged
8 tasks
deepankarb added a commit that referenced this issue Jun 28, 2021
@deepankarb
Cleanup DB exceptions, fixes #510
f291693 
* Removed unused exceptions
* Refactored ResourceNotFoundException and removed redundant copy
FHIR engine library automation moved this from To do to Done Jun 28, 2021
deepankarb added a commit that referenced this issue Jun 28, 2021
@deepankarb
Cleanup DB exceptions, fixes #510 (#599)
301bb92 
* Removed unused exceptions
* Refactored ResourceNotFoundException and removed redundant copy
@f-odhiambo f-odhiambo mentioned this issue Aug 2, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepankarb deepankarb

@jingtang10 jingtang10

Labels
type:enhancement New feature or request
Projects
Android FHIR SDK
Archived in project
FHIR engine library
  
Done
Milestone
Q2 June 2021
Development

Successfully merging a pull request may close this issue.

Cleanup DB exceptions google/android-fhir
4 participants
@fredhersch @deepankarb @jingtang10 @Tarun-Bhardwaj