Rework sync API to be separate from data access API #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
deepankarb
reviewed
May 19, 2021
|
|
||
| fun updatePeriodicSyncConfiguration(syncConfig: PeriodicSyncConfiguration) | ||
| suspend fun syncUpload(upload: (suspend (List<SquashedLocalChange>) -> List<LocalChangeToken>)) |
There was a problem hiding this comment.
I think we're leaking DB abstraction here. We'll have to think of a way to do decouple keeping the abstractions.
jingtang10
changed the title
jingtang10
requested review from
kevinmost,
pankajkatoch and
yigit
as code owners
yigit
requested changes
May 20, 2021
engine/src/main/java/com/google/android/fhir/db/impl/dao/SyncedResourceDao.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/impl/FhirEngineImpl.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/impl/FhirEngineImpl.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/FhirSynchronizer.kt
Outdated
Show resolved
Hide resolved
reference/src/main/java/com/google/android/fhir/reference/PatientListActivity.kt
Outdated
Show resolved
Hide resolved
jingtang10
force-pushed
the
jt/sync
branch
2 times, most recently
from
3a85b76
to
d532933
Compare
yigit
requested changes
May 26, 2021
engine/src/main/java/com/google/android/fhir/db/impl/DatabaseImpl.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/db/impl/DatabaseImpl.kt
Outdated
Show resolved
Hide resolved
| * true if the SDK needs to retry a failed sync attempt, false otherwise If this is set to true, | ||
| * then the result of the sync will be reported after the retry. | ||
| */ | ||
| val retry: Boolean = false |
This was referenced May 27, 2021
yigit
approved these changes
May 27, 2021
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #[issue number]
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project./gradlew checkand./gradlew connectedCheckto test my changes locally