Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new resources on the server using POST #760

Closed
aditya-07 opened this issue Aug 27, 2021 · 2 comments · Fixed by #2137, #2166, #2121, #2147 or #2109
Closed

Create new resources on the server using POST #760

aditya-07 opened this issue Aug 27, 2021 · 2 comments · Fixed by #2137, #2166, #2121, #2147 or #2109
Assignees
Labels
effort:large Large effort - 5 to 10 days P1 High priority issue type:enhancement New feature or request

Comments

@aditya-07
Copy link
Collaborator

aditya-07 commented Aug 27, 2021

We need to support create using POST in the sync API.

**Describe the bug** Locally created Resources are assigned ID at creation/before saving to the local db. Once this Resource is up-synced, the server assigns a new ID to the resource and disregards the assigned ID (in case of HTTP-POST). The created object is returned in the POST response. Since the lD for local & remote copy are different now, need to update all the local id references with the remote id.

Component
Core library, SDC library, reference app, or SDC gallery app

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: [e.g. Pixel4a emulator]
  • Android version: [e.g. Settings -> About phone -> Android version]
  • Build number: [e.g. Settings -> About phone -> Build number]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

@aditya-07 aditya-07 added type:bug Something isn't working type:enhancement New feature or request labels Aug 27, 2021
@aditya-07 aditya-07 added this to To do in FHIR engine library via automation Aug 27, 2021
@aditya-07 aditya-07 self-assigned this Aug 30, 2021
@Tarun-Bhardwaj Tarun-Bhardwaj removed the type:enhancement New feature or request label Aug 30, 2021
@Tarun-Bhardwaj Tarun-Bhardwaj added the P1 High priority issue label Sep 8, 2021
@jingtang10 jingtang10 added P2 Medium priority issue and removed P1 High priority issue labels Mar 31, 2022
@jingtang10
Copy link
Collaborator

lowering the priority since we do not use POST any more. we are explicitly supporting PUT for creating resources (for now). it is possible that we will need to add support for POST in the future so keeping this issue open.

@jingtang10 jingtang10 added type:enhancement New feature or request P1 High priority issue effort:large Large effort - 5 to 10 days and removed type:bug Something isn't working P2 Medium priority issue labels Jul 13, 2023
@jingtang10 jingtang10 changed the title Update id of local created Resources in the local database after up syncing Create new resources on the server using POST Jul 13, 2023
@jingtang10 jingtang10 self-assigned this Aug 14, 2023
@fredhersch fredhersch added this to the FHIR Engine beta04 milestone Aug 21, 2023
@jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 removed this from the FHIR Engine beta04 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment