Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to update the resource id and its references. #775

Closed
wants to merge 2 commits into from

Conversation

aditya-07
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #760

Description
Changes to update the resource id and its references incase a new resource id is assigned to the Resource after up-sync (http POST)

Alternative(s) considered
No
Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read How to Contribute
  • I have read the Developer's guide
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

…ource id is assigned to the Resource after upsync (http POST)
@Tarun-Bhardwaj
Copy link

@aditya-07 , are changes on this PR complete so that @jingtang10 can review?

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #775 (edd096a) into master (c06c2a3) will decrease coverage by 31.61%.
The diff coverage is 0.00%.

❗ Current head edd096a differs from pull request most recent head ec5ac09. Consider uploading reports for the commit ec5ac09 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #775       +/-   ##
=============================================
- Coverage     84.53%   52.91%   -31.62%     
+ Complexity      608      197      -411     
=============================================
  Files           134       48       -86     
  Lines         10279     1030     -9249     
  Branches        756      147      -609     
=============================================
- Hits           8689      545     -8144     
+ Misses         1214      400      -814     
+ Partials        376       85      -291     
Impacted Files Coverage Δ
...va/com/google/android/fhir/db/impl/DatabaseImpl.kt 32.00% <0.00%> (-58.13%) ⬇️
.../google/android/fhir/db/impl/dao/LocalChangeDao.kt 68.75% <ø> (-14.27%) ⬇️
...oogle/android/fhir/db/impl/dao/LocalChangeUtils.kt 85.10% <ø> (+0.32%) ⬆️
...com/google/android/fhir/db/impl/dao/ResourceDao.kt 66.66% <0.00%> (-16.83%) ⬇️
...e/android/fhir/db/impl/entities/DateIndexEntity.kt 100.00% <ø> (ø)
...droid/fhir/db/impl/entities/DateTimeIndexEntity.kt 100.00% <ø> (ø)
...android/fhir/db/impl/entities/NumberIndexEntity.kt 100.00% <ø> (ø)
...droid/fhir/db/impl/entities/PositionIndexEntity.kt 0.00% <ø> (ø)
...droid/fhir/db/impl/entities/QuantityIndexEntity.kt 100.00% <ø> (ø)
...roid/fhir/db/impl/entities/ReferenceIndexEntity.kt 100.00% <ø> (ø)
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff505e...ec5ac09. Read the comment docs.

@jingtang10
Copy link
Collaborator

can this be closed if we're not going to do this now? @aditya-07

@jingtang10
Copy link
Collaborator

we will close this pr for now since we're using batch transaction with PUT and PATCH for updating.

@jingtang10 jingtang10 closed this Mar 31, 2022
FHIR engine library automation moved this from In progress to Done Mar 31, 2022
@jingtang10 jingtang10 deleted the ak/resource-id-update branch July 1, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create new resources on the server using POST
3 participants