Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring UploadRequestGenerator for Upload Sync Redesign #2168

Merged
merged 9 commits into from
Sep 15, 2023

Conversation

anchita-g
Copy link
Collaborator

@anchita-g anchita-g commented Sep 14, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description

  • Refactored Request into DownloadRequest and UploadRequest and moved them into appropriate packages.
  • Refactored IndividualRequestGenerator to UrlRequestGenerator to bring it more in line with the type of UploadRequest
  • Created UploadRequestGeneratorMode to support creation of appropriate UploadRequestGenerator

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@anchita-g anchita-g changed the title Refactoring UploadRequestGenerator for Upload Redesign Refactoring UploadRequestGenerator for Upload Sync Redesign Sep 14, 2023
@omarismail94 omarismail94 merged commit 8c1c9e7 into google:master Sep 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants