-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Auto complete widget #1398
Refactor Auto complete widget #1398
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1398 +/- ##
============================================
+ Coverage 89.74% 90.08% +0.33%
Complexity 646 646
============================================
Files 129 129
Lines 9879 9839 -40
Branches 742 713 -29
============================================
- Hits 8866 8863 -3
+ Misses 622 591 -31
+ Partials 391 385 -6
Continue to review full report at Codecov.
|
Here are my thoughts:
|
|
@KhumboLihonga These recommendations sound good to me from a UX perspective.
|
@aditya-07 can you please resolve the conflicts? thanks! |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #978
Description
FlexboxLayout
and used materialChipGroup
to add Chips for selected answers.Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug fix
Screenshots (if applicable)
![Auto-Complete](https://user-images.githubusercontent.com/18224849/169001688-a2fbe473-bda4-4644-a1ea-20642739dafd.png)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.