Review screen ux changes like font style, error icon, not answered text color etc. #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before After |
|
@santosh-pingle looks great. I've realized a new issue that I think we can improve for this view. The current design of "not answered" isn't clear enough and people might miss that this field hasn't been completed. My suggestion is to make that text red (error color) and to add an error icon. See below. |
… value is not answered.
santosh-pingle
changed the title
|
@shelaghm
|
|
@santosh-pingle Great! Can you check the red text color? It looks too light, it should be |
|
|
santosh-pingle
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
jingtang10
requested changes
Jan 5, 2023
catalog/src/main/java/com/google/android/fhir/catalog/DemoQuestionnaireFragment.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireFragment.kt
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemHeaderViewUtil.kt
Outdated
Show resolved
Hide resolved
...pture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemHeaderView.kt
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemHeaderViewUtil.kt
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemHeaderViewUtil.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/res/layout/questionnaire_item_simple_question_answer_view.xml
Outdated
Show resolved
Hide resolved
...roid/fhir/datacapture/views/QuestionnaireItemSimpleQuestionAnswerDisplayViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...roid/fhir/datacapture/views/QuestionnaireItemSimpleQuestionAnswerDisplayViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemViewItem.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Jan 13, 2023
...roid/fhir/datacapture/views/QuestionnaireItemSimpleQuestionAnswerDisplayViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...roid/fhir/datacapture/views/QuestionnaireItemSimpleQuestionAnswerDisplayViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/res/layout/questionnaire_item_simple_question_answer_view.xml
Outdated
Show resolved
Hide resolved
datacapture/src/main/res/layout/questionnaire_item_simple_question_answer_view.xml
Outdated
Show resolved
Hide resolved
|
Addressing review comments, thanks! |
jingtang10
requested changes
Mar 1, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreHeaderViews.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreHeaderViews.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreHeaderViews.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Mar 6, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireFragment.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1716
Description
Issue : Question text font style of edit mode get applied to the question text in review mode.
Fix : Created separate header item view for review mode so that title medium text style can be applied.
Do not show the help button in the review mode.
Show an error icon and not answered text in the error color if question is not answered, refer ux design.
Move common functions of header view item to new file.
Apply style to item divider in review mode.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.