Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize flatten and descendent traversal #2079

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Optimize flatten and descendent traversal #2079

merged 3 commits into from
Jul 20, 2023

Conversation

omarismail94
Copy link
Contributor

@omarismail94 omarismail94 commented Jul 19, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2071

Description
Append to a mutable list, rather than creating a new list at every recursive call and then adding all its elements to the parent list

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10
Copy link
Collaborator

update the pr description to code health

@omarismail94
Copy link
Contributor Author

Thanks @jingtang10 ! Updated description and applied your changes

@omarismail94 omarismail94 merged commit 1ba6cd6 into google:master Jul 20, 2023
2 of 3 checks passed
@omarismail94 omarismail94 deleted the fixme branch July 20, 2023 05:54
MJ1998 pushed a commit to MJ1998/android-fhir that referenced this pull request Jul 20, 2023
ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Aug 11, 2023
- X-FHIR-Query support for variable extension PR google#2076
- Optimize flatten and descendent traversal PR google#2079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Slow performance on large Questionnaire
3 participants