Use ktfmt in spotless and switch (back) to google-java-format #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingtang10
requested review from
deepankarb,
joiskash,
pankajkatoch and
yigit
as code owners
Closed
Closed
jingtang10
requested review from
kunjan8794,
MuhammadSalman-7214,
pld and
kevinmost
MuhammadSalman-7214
approved these changes
Mar 10, 2021
|
thanks @MuhammadSalman-7214 and @joiskash for taking a look. To other reviewers, if there's too much to go through, please focus on the non-kotlin files. Namely, the |
|
changing java version used in github action which might have an impact on the integration tests |
deepankarb
approved these changes
Mar 10, 2021
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying out a few different linter options in spotless (see documentation) and using a few different IDE plugins available for kotlin formatting in Android Studio, I've really seen the advantages of using ktfmt but decided to keep also ktlint in the list of linters in spotless (you can use multiple linters).
The documentation here explains quite well why they decided to use google-java-format, not the least because of the rectangle rule. It's very deterministic, which means it really takes formatting away as a concern for the developer.
See the linked issue for a bit more background.