Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test out of memory for API 29 #73

Closed
jingtang10 opened this issue Jul 1, 2020 · 5 comments · Fixed by #116, #193 or #294
Closed

Integration test out of memory for API 29 #73

jingtang10 opened this issue Jul 1, 2020 · 5 comments · Fixed by #116, #193 or #294
Assignees
@deepankarb
Projects
FHIR engine library

Comments

@jingtang10
Copy link
Collaborator

jingtang10 commented Jul 1, 2020 •
edited

In recent github action runs for PRs, tests for API 29 consistently failed due to out of memory issue. e.g:

com.google.fhirengine.db.impl.DatabaseImplTest > select_invalidResourceType_shouldThrowIllegalArgumentException[test(AVD) - 10] FAILED
java.lang.OutOfMemoryError: OutOfMemoryError thrown while trying to throw an exception; no stack trace available

See trace: https://github.com/google/android-fhir/runs/824594488

Note this doesn't happen for API 24 or 27, nor does this happen locally.
@deepankarb
Copy link
Contributor

This might be fixed by #74. Will close if the next few actions succeed.

@jingtang10 jingtang10 assigned jingtang10 and deepankarb and unassigned jingtang10 Jul 1, 2020
@deepankarb deepankarb mentioned this issue Nov 30, 2020
Merged
@jingtang10 jingtang10 linked a pull request Dec 1, 2020 that will close this issue
Integration test out of memory for API 29 #73 #89
Closed
@deepankarb
Copy link
Contributor

Still seeing OOM failures on some branches.

@deepankarb deepankarb reopened this Dec 2, 2020
@jingtang10 jingtang10 linked a pull request Dec 3, 2020 that will close this issue
API 29 CI OOM fix #119
Closed
@deepankarb deepankarb mentioned this issue Feb 11, 2021
Closed
@jingtang10
Copy link
Collaborator Author

A more recent run: https://github.com/google/android-fhir/runs/2054399134?check_suite_focus=true

This blocked code submission over the weekend. We should treat this as high-priority.

@jingtang10 jingtang10 linked a pull request Mar 8, 2021 that will close this issue
Use the latest version of reactive circus #193
Merged
@jingtang10
Copy link
Collaborator Author

Related issue: ReactiveCircus/android-emulator-runner#131

@jingtang10 jingtang10 moved this from Done to In progress in FHIR engine library Mar 9, 2021
@jingtang10 jingtang10 linked a pull request Mar 10, 2021 that will close this issue
Use ktfmt in spotless and switch (back) to google-java-format #294
Merged
FHIR engine library automation moved this from In progress to Done Mar 10, 2021
@jingtang10 jingtang10 reopened this Mar 10, 2021
FHIR engine library automation moved this from Done to In progress Mar 10, 2021
@jingtang10 jingtang10 mentioned this issue Mar 10, 2021
Merged
@jingtang10 jingtang10 linked a pull request Mar 18, 2021 that will close this issue
Stop Gradle before running the integration tests #338
Closed
@jingtang10 jingtang10 removed a link to a pull request Mar 18, 2021
Use ktfmt in spotless and switch (back) to google-java-format #294
Merged
This was linked to pull requests Mar 18, 2021
Use ktfmt in spotless and switch (back) to google-java-format #294
Merged
Move gradle build after gradle connectedCheck #339
Closed
Start using Android Test Orchestrator #353
Closed
@jingtang10
Copy link
Collaborator Author

This has not been happening - let's close for now and reopen if recurs.

FHIR engine library automation moved this from In progress to Done May 11, 2021
JoseAlcerreca added a commit to android/nowinandroid that referenced this issue May 12, 2022
@JoseAlcerreca
replace 29 for 31
1551d6e 
looks like 29 has memory issues google/android-fhir#73
JolandaVerhoef added a commit to android/nowinandroid that referenced this issue May 12, 2022
@JolandaVerhoef @JoseAlcerreca
Add github-specific setup (#1)
ae0cc71 
* Add github-specific setup

Change-Id: Iad8edf3c16182807eda6893c696244d9147f7cab

* Update Build.yaml

Replaces cC for cAT

* Filters out benchmark tests

* Trying to increase storage with disk.dataPartition.size

* Increasing size a bit more for API 23

* Remove API 23

* Reverting, using correct param name

* Increase again to 1500M

* heap=512M

java.lang.OutOfMemoryError: java.lang.OutOfMemoryError: OutOfMemoryError thrown while trying to throw an exception; no stack trace available

* replace 29 for 31

looks like 29 has memory issues google/android-fhir#73

* API 30

* Arch x86_64 as there's no API 30 x86

Co-authored-by: Jose Alcérreca <JoseAlcerreca@users.noreply.github.com>
This was referenced May 13, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepankarb deepankarb

Labels
None yet
Projects
Android FHIR SDK
Archived in project
FHIR engine library
  
Done
Milestone
No milestone
2 participants
@deepankarb @jingtang10