Skip to content

Commit

Permalink
Merge pull request #260 from charlesccychen/fix-keyfile
Browse files Browse the repository at this point in the history
Use binary read for SignedJwtAssertionCredentials
  • Loading branch information
jameslynnwu committed Feb 28, 2019
2 parents 373a929 + bbf438a commit 1211a8d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion apitools/base/py/credentials_lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def ServiceAccountCredentialsFromP12File(
return credentials
else:
# oauth2client < 2.0.0
with open(private_key_filename) as key_file:
with open(private_key_filename, 'rb') as key_file:
return oauth2client.client.SignedJwtAssertionCredentials(
service_account_name, key_file.read(), scopes,
user_agent=user_agent)
Expand Down

0 comments on commit 1211a8d

Please sign in to comment.