Fix an ADC-related bug, and make an install tweak. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting the application default credentials from a file, we need to make sure we call create_scoped(), otherwise we'll get back invalid access tokens. While I was here, I dropped the hook to add an oauth2l script, since it's now its own package on PyPI. I'll drop the code in a separate PR.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting the application default credentials from a file, we need to make
sure we call create_scoped(), otherwise we'll get back invalid access tokens.
While I was here, I dropped the hook to add an oauth2l script, since it's now
its own package on PyPI. I'll drop the code in a separate PR.
PTAL @wora