Upgrading oauth2client.tools.run to run_flow.

[dhermes]

@craigcitro I assume this won't be sufficient / you need some legacy support for gflags.

NOTE: I reference the warning for the out-of-date method in googleapis/google-cloud-python#755

---

I tested this with

# gen_client --discovery_url=storage.v1 --nogenerate_cli --outdir=storage client
from storage import storage_v1_client as storage_client
from storage import storage_v1_messages as storage_messages
client = storage_client.StorageV1()

and it works just fine.

[coveralls]

Coverage decreased (-0.0%) to 39.85% when pulling 06cbb7c on dhermes:upgrade-to-runflow into 74c7af5 on google:master.

[coveralls]

Coverage decreased (-0.0%) to 39.85% when pulling 06cbb7c on dhermes:upgrade-to-runflow into 74c7af5 on google:master.

[coveralls]

Coverage decreased (-0.0%) to 39.85% when pulling 06cbb7c on dhermes:upgrade-to-runflow into 74c7af5 on google:master.

[craigcitro]

yeah, i can't just drop gflags -- it'll break all internal use of this code.

the only option here is the (awkward) "try gflags and tools.run, then fall back to argparse and tools.run_flow". i almost think we should just roll that into oauth2client, but i haven't really thought it through.

[dhermes]

Nope, there is a "better" option that let's you move off of gflags at your own pace:

flags = argparse.Namespace(auth_host_name=FLAGS.auth_host_name,
                           auth_host_port=FLAGS.auth_host_port,
                           logging_level='ERROR',
                           noauth_local_webserver=not FLAGS.auth_local_webserver)

[craigcitro]

ah, so you're saying we can drop tools.run for tools.run_flow -- we just need to conditionally load from flags.FLAGS or a passed-in namespace. sgtm.

[dhermes]

@craigcitro PTAL. I made the changes to incorporate gflags and added a test for the method I added.

[dhermes]

@craigcitro I ported this comment from the actual changed section below. It seems to be out-of-date (i.e. the slow import is just oauth2client.crypt or anything that imports it) but I left it in just in case.

[craigcitro]

yeah, i vaguely remember running into this and not digging much. you can probably drop this whole comment now (since we use tools for the arg parser).

[dhermes]

It's still needed for the gflags declarations because it imports old_run. The "long time" thing is what I was getting hung up on.

[craigcitro]

LGTM, one or two little comments/questions

[dhermes]

Yup. I've got 4 changes to make and one remaining question for you (about FLAGS is None vs. checking attrs)

[dhermes]

@craigcitro I pushed over the original commit with the changes. Main update is just checking for each attribute on FLAGS. PTAL.

[craigcitro]

nit: It is ambiguous (is it the next declaration or the previous one?). maybe either name the module or keep it on the same line?

[craigcitro]

looks great -- one really nitpicky comment and then we're good to go. 👍

[dhermes]

Yeah I noticed the ambiguous it too. Removing a line is not always sufficient in a human language :)

Addressed and pushed over the original commit.