Include 201 CREATED in HTTP success response codes #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we only accepted 200 OK and 204 NO_CONTENT. Some APIs we'd like to use this library with return 201 CREATED when creating a resource, so that should also count as success (and behave like 200 OK).
|
Lint checks are failing on travis: https://travis-ci.org/google/apitools/builds/392829610?utm_source=github_status&utm_medium=notification. |
vilasj
approved these changes
Jun 15, 2018
sixolet
added a commit
to sixolet/apitools
that referenced
this pull request
Aug 7, 2018
* Include 201 CREATED in HTTP success response codes Previously, we only accepted 200 OK and 204 NO_CONTENT. Some APIs we'd like to use this library with return 201 CREATED when creating a resource, so that should also count as success (and behave like 200 OK).
sixolet
added a commit
to sixolet/apitools
that referenced
this pull request
Aug 7, 2018
* Include 201 CREATED in HTTP success response codes Previously, we only accepted 200 OK and 204 NO_CONTENT. Some APIs we'd like to use this library with return 201 CREATED when creating a resource, so that should also count as success (and behave like 200 OK).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only accepted 200 OK and 204 NO_CONTENT. Some APIs we'd like to use this library with return 201 CREATED when creating a resource, so that should also count as success (and behave like 200 OK).