Fix mock for urllib_request in GetURLContentTest #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were replacing the urlopen and it wasn't being unmocked, so other tests got the value 'regular non-gzipped content' when calling urlopen.
houglum
approved these changes
Jun 26, 2019
|
Context: This (the way the code was before your change) doesn't screw anything up now, since the test is torn down once those two methods are finished, but it would break things if we added another method in the future. +1 to this change, since it removes side effects that were previously sticking around after an individual test was finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were replacing the urlopen and it wasn't being unmocked, so other tests got the value 'regular non-gzipped content' when calling urlopen.