Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pager helper to work with nested fields for limit or continuation token #281

Merged
merged 5 commits into from
Sep 25, 2019

Conversation

sixolet
Copy link
Contributor

@sixolet sixolet commented Sep 19, 2019

Allow a limit or a continuation token to be in a nested field in the list request or response.

This allows, for example, if the continuation token is metadata.continue_ like it is for a Kubernetes-style api, where metadata is a ListMeta and common to all list responses.

This still needs a little more tests.

@coveralls
Copy link

coveralls commented Sep 19, 2019

Coverage Status

Coverage increased (+0.02%) to 91.71% when pulling 943aedb on sixolet:nested-fields-pager into 1a950d5 on google:master.

@sixolet
Copy link
Contributor Author

sixolet commented Sep 24, 2019

Ok, here we go. Docstrings added, lint fixed, not rewritten as iterative as discussed out of band (it's clearer code in recursive form)

@jameslynnwu jameslynnwu merged commit 6d64cb6 into google:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants