Add compatibility with httplib2 0.16.0+ #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See more at googleapis/google-api-python-client#803. Fix applied as recommended in googleapis/google-api-python-client#803 (comment)
|
Hi @houglum, do you think you can help review this and create a patch release? |
|
I've mostly moved away from doing gsutil (and associated projects') maintainence; you'll want to poke @dilipped for a review :) |
|
The change looks good to me, but I have never worked on this lib before, so if one of the previous contributors can take a look as well then that would be great. @jameslynnwu I see that you have approved PRs in the past, can you please take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See more at googleapis/google-api-python-client#803.
Fix applied as recommended in googleapis/google-api-python-client#803 (comment)