Remove google.apputils/gflags usage in favor of argparse. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| proto_parser.set_defaults(func=GenerateProto) | ||
|
|
||
| args = parser.parse_args(argv[1:]) | ||
| args.func(args) |
There was a problem hiding this comment.
we probably want to get a return value here, and then return either that or 0 (since we might fall off the end of a function and return None in places).
then we want to sys.exit(main()) below.
|
wahoo! this is super awesome. just one small nit with return values and we should be good to go. |
cherba
force-pushed
the
gen_client_argparse
branch
from
1cb9604
to
b4b439c
Compare
This PR converts apitools.gen.gen/gen_client.py to use python standard argparse for command line argument parsing. Note that now type of generation argument must occur last on the command line.
cherba
force-pushed
the
gen_client_argparse
branch
from
b4b439c
to
a2117ba
Compare
|
w00t! |
craigcitro
added a commit
that referenced
this pull request
Sep 12, 2015
Remove google.apputils/gflags usage in favor of argparse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts apitools.gen.gen/gen_client.py to use python standard argparse for command line argument parsing. Note that now type of generation argument must occur last on the command line.