Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Is this lib production ready or deprecated? #162

Open
fzyzcjy opened this issue Dec 23, 2020 · 9 comments
Open

Is this lib production ready or deprecated? #162

fzyzcjy opened this issue Dec 23, 2020 · 9 comments

Comments

@fzyzcjy
Copy link

fzyzcjy commented Dec 23, 2020

Hi thanks for the lib! I wonder whether this lib is ready to be used in production environment, or it is already deprecated (seems nobody is maintaining it...)? Thanks!

@pspencil
Copy link

pspencil commented Dec 23, 2020 via email

@fzyzcjy
Copy link
Author

fzyzcjy commented Dec 23, 2020

@pspencil Thanks! Sorry I am a bit confused: What is "native libraries"? IMHO this github repo only has java code...

@pspencil
Copy link

Look inside this dir. https://www.github.com/google/archive-patcher/tree/v2/generator%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Farchivepatcher%2Fgenerator%2Fbsdiff%2Fwrapper

It uses the native bsdiff implementation. The java version should also work. But it is just slower (and not used for a long time so not the same guarantees)

@fzyzcjy
Copy link
Author

fzyzcjy commented Dec 23, 2020

@pspencil Ha interesting! So how do I use that instead of the java one? You mentioned that I cannot use gradle to build it. Thank you!

@andrewhayden
Copy link
Contributor

I can no longer speak for the team on this, but the pure-java version in tag "1.0 " (https://github.com/google/archive-patcher/releases/tag/1.0) is quite stable. Depending on your use case, the performance may / may not be a problem. I'd personally (again not speaking for the team here) encourage you to try it out and see if its performance is adequate to your needs.

@fzyzcjy
Copy link
Author

fzyzcjy commented Dec 23, 2020

@andrewhayden Thank you very much! I have downloaded https://dl.bintray.com/juliantoledo/Maven/archive-patcher-1.0.jar several hours ago, and that speed (>10 seconds) is acceptable for me though a little bit slow.

@fzyzcjy
Copy link
Author

fzyzcjy commented Dec 23, 2020

@pspencil @andrewhayden By the way, a curious question: Does Google Play uses this for downloading app? If so, that sounds awesome!

@pspencil
Copy link

Yes it is one of the options.

@pauloavelar
Copy link

Hello. Let me piggyback this issue because the question relates to the production-readiness of the library.

Is there a release plan for v2? I see commits being synced recently and the new generateDelta interface with ByteSource instead of File is something I could really use.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants