redact_arg_values throws a parse error on Options of type Vec #111

BobEvans · 2021-12-07T17:59:35Z

In Fuchsia's ffx tool, there is a declaration of an Option type, --config that can be a Vec.
from_args has no problem with invocations such as

ffx --config x --config y

However, redact_arg_values throws a parse error in ParseSlotValue that a duplicate value, y, was provided. It seems to be mistaking the Option type for a variant that has one value.

This is preventing the majority of analytics use cases from working for ffx.

This changes argh_derive to handle redacting types like: ``` struct Cmd { #[argh(option)] /// fooey arg: Vec<String>, } ``` Fixes google#111

This changes argh_derive to handle redacting types like: ``` struct Cmd { #[argh(option)] /// fooey arg: Vec<String>, } ``` Fixes #111

erickt added a commit to erickt/argh that referenced this issue Dec 7, 2021

Fix redacting Vec<T> options

6c33cbd

This changes argh_derive to handle redacting types like: ``` struct Cmd { #[argh(option)] /// fooey arg: Vec<String>, } ``` Fixes google#111

erickt mentioned this issue Dec 7, 2021

Fix some redaction bugs #112

Merged

erickt added a commit to erickt/argh that referenced this issue Dec 7, 2021

Fix redacting Vec<T> options

69a8bb6

This changes argh_derive to handle redacting types like: ``` struct Cmd { #[argh(option)] /// fooey arg: Vec<String>, } ``` Fixes google#111

erickt closed this as completed in #112 Dec 8, 2021

erickt added a commit that referenced this issue Dec 8, 2021

Fix redacting Vec<T> options

5676ea1

This changes argh_derive to handle redacting types like: ``` struct Cmd { #[argh(option)] /// fooey arg: Vec<String>, } ``` Fixes #111

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

redact_arg_values throws a parse error on Options of type Vec #111

redact_arg_values throws a parse error on Options of type Vec #111

BobEvans commented Dec 7, 2021

redact_arg_values throws a parse error on Options of type Vec #111

redact_arg_values throws a parse error on Options of type Vec #111

Comments

BobEvans commented Dec 7, 2021