Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs on how to debug the derived marco #131

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

qhua948
Copy link
Contributor

@qhua948 qhua948 commented Jun 24, 2022

No description provided.

docs/argh_derive_expand/Cargo.lock Outdated Show resolved Hide resolved
docs/argh_derive_expand/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@erickt erickt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than putting argh_derive_expand, what do you think about moving it into examples/example.rs, since we don't have a proper compilable example? cargo expand --example example should still expand the macros.

If we go down this road, can you update https://github.com/google/argh/blob/master/.github/workflows/rust.yml to make sure the example is automatically built?

@qhua948
Copy link
Contributor Author

qhua948 commented Jul 13, 2022

Rather than putting argh_derive_expand, what do you think about moving it into examples/example.rs, since we don't have a proper compilable example? cargo expand --example example should still expand the macros.

If we go down this road, can you update https://github.com/google/argh/blob/master/.github/workflows/rust.yml to make sure the example is automatically built?

It did not like very much

 $ cargo expand --example simple_example.rs
error: manifest path `/workspace/argh/Cargo.toml` is a virtual manifest, but this command requires running against an actual package in this workspace

@qhua948
Copy link
Contributor Author

qhua948 commented Jul 13, 2022

nvm I figured it out

Copy link
Collaborator

@erickt erickt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you fix the cargo fmt error though?

@qhua948
Copy link
Contributor Author

qhua948 commented Jul 14, 2022

Done

@qhua948 qhua948 force-pushed the docs-cargo-expand branch 3 times, most recently from 26759aa to e2e5b31 Compare July 19, 2022 03:20
@erickt erickt merged commit f68d472 into google:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants