Support generic structs and enums in derive(FromArgs) #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickt
approved these changes
Sep 21, 2022
I don't think there's a useful way to break down the type it complains about on argh/src/lib.rs:981, so just let it ignore that one.
This removes the restriction against deriving a struct with FromArgs that takes generic arguments, and adds a test to make sure it works correctly. There isn't really a good reason for this constraint as far as I can tell, and it's surprising if you run into it.
stormbrew
force-pushed
the
support-generics
branch
from
8cb2ab2
to
eaf5a88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the restriction against deriving a struct with FromArgs that takes generic arguments, and adds a test to make sure it works correctly. There isn't really a good reason for this constraint as far as I can tell, and it's surprising if you run into it.