Add 'remainder': greedy positional arguments #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormbrew
force-pushed
the
remainder-positional
branch
from
6d899cc
to
8ab93b7
Compare
erickt
requested changes
Sep 22, 2022
argh/src/lib.rs
Outdated
| // Don't increment position if we're at the last arg | ||
| // *and* the last arg is repeating. If it's also remainder, | ||
| // halt non-option processing after this. | ||
| println!("{}", self.last_is_greedy); |
There was a problem hiding this comment.
Looks like some debug code.
There was a problem hiding this comment.
Wow yep, that would have been unfortunate to leave in. Good catch.
| c: None, | ||
| d: vec!["foo".into(), "bar".into(), "--c".into(), "hi".into()], | ||
| }, | ||
| ); |
There was a problem hiding this comment.
could you add a check that this still plays nicely with --? With something like:
assert_output(
&["5", "foo", "bar", "--", "hi"],
LastRepeatingGreedy {
a: 5,
b: false,
c: None,
d: vec!["foo".into(), "bar".into(), "--".into(), "hi".into()],
},
);
This adds a new variant of positional arguments that, once they start processing, consume all arguments after as part of the positional argument, as if they always had '--' in front or behind them.
stormbrew
force-pushed
the
remainder-positional
branch
from
8ab93b7
to
74c2804
Compare
erickt
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new variant of positional arguments that, once they start processing, consume all arguments after as part of the positional argument, as if they always had '--' in front or behind them.
We need this for deferring subcommand parsing in ffx until after we've read the main command's arguments.