-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support time binding comparisons inside HAVING clauses #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerlucena
force-pushed
the
at-binding-comparison
branch
2 times, most recently
from
August 17, 2020 17:40
179752d
to
bc200ec
Compare
rogerlucena
force-pushed
the
at-binding-comparison
branch
3 times, most recently
from
August 18, 2020 22:42
47d3630
to
f6ca722
Compare
…ression_test.go")
rogerlucena
force-pushed
the
at-binding-comparison
branch
from
August 21, 2020 13:46
f6ca722
to
d73ca3d
Compare
rbkloss
requested review from
rbkloss and
thiagovas
and removed request for
rbkloss
August 21, 2020 13:54
rbkloss
approved these changes
Aug 21, 2020
thiagovas
approved these changes
Aug 22, 2020
…hem as Test Helpers
jlsotomayorm
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we extract a time binding inside the
WHERE
clause it would be useful to be able to use it for comparisons inside theHAVING
clause, creating conditions around that binding. This PR comes to add support for this.To illustrate, the query below is now possible:
On which the time binding
?time
extracted with theAT
keyword can now be compared to a time literal (2016-03-01T00:00:00-08:00
above) inside the HAVING clause.You can also combine it with
ID
bindings to create more complex conditions inside theHAVING
clause:NB: The comparisons with a time literal are not lexicographical, they indeed have the semantics of a time comparison: we consider the time zone, for example (as one should expect).
So, if you use a condition like
?time = 2012-03-10T00:00:00-08:00
in yourHAVING
clause, you may also get triples in your query result with the?time
binding being2012-03-10T09:00:00+01:00
(which is equivalent to the timestamp requested in the condition, being in another time zone).For more examples on this, please refer to the new tests added in
planner_test.go
andexpression_test.go
.