Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructing error messages in the case of node binding inequalities inside HAVING clauses #138

Merged
merged 3 commits into from
Sep 8, 2020

Conversation

rogerlucena
Copy link
Contributor

From now on, comparisons between a node binding and a node literal inside HAVING clauses can only be equalities, such as in:

SELECT ?s, ?height
FROM ?test
WHERE {
    ?s "height_cm"@[] ?height
}
HAVING ?s = /u<bob>;

Note that node inequalities are not allowed anymore because they may raise confusion with regards to what is indeed being compared (only the ID, only the TYPE, or both together).

In the case of inequalities an error is prompted orienting the user to extract bindings with the ID/TYPE keywords and to use these bindings to proceed with the comparisons in a clearer way.

@thiagovas thiagovas merged commit 9c6933b into google:master Sep 8, 2020
@rogerlucena rogerlucena deleted the node-equality-having branch September 8, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants