[FR] clang static analyzer: src/include/benchmark/benchmark.h:1069:3: Potential memory leak [cplusplus.NewDeleteLeaks]

[LebedevRI]

https://github.com/darktable-org/rawspeed/actions/runs/3574871458/jobs/6011864553#step:23:314

benchmark/include/benchmark/benchmark.h

Lines 1272 to 1276 in 2257fa4

	inline internal::Benchmark* RegisterBenchmark(const char* name,
	internal::Function* fn) {
	return internal::RegisterBenchmarkInternal(
	::new internal::FunctionBenchmark(name, fn));
	}

triggers clang static analyzer reports:

[HIGH] /__w/rawspeed/rawspeed/rawspeed-build/src/external/googlebenchmark/src/include/benchmark/benchmark.h:1069:3: Potential memory leak [cplusplus.NewDeleteLeaks]
  return internal::RegisterBenchmarkInternal(
  ^

Found 1 defect(s) in benchmark.h

It would be really good to either completely rewrite that code to avoid the issue in the first place,
or at least silence it as a known false-positive.

[HFTrader]

I could not replicate this. Using clang 17 (trunk) and benchmark/main as of today.

[LebedevRI]

Still happening: https://github.com/darktable-org/rawspeed/actions/runs/4367100895/jobs/7637984919#step:29:275

[dmah42]

can we add that static analysis to the benchmark CI bots?

[LebedevRI]

Still happening: https://github.com/darktable-org/rawspeed/actions/runs/4367100895/jobs/7637984919#step:29:275

(Err, of course that is with clang-15, maybe it's gone in clang-16, i don't know yet.)

[HFTrader]

How did you run? Just scan-build make?

[LebedevRI]

As you can see in that very log, by running CodeChecker over the compile_commands.json.

[HFTrader]

It looks like CodeChecker uses scan-build under the hood, right? Let me try with clang-15 or earlier.

[LebedevRI]

Yup, the warning is still there with clang-16, as expected:
https://github.com/darktable-org/rawspeed/actions/runs/5428151349/jobs/9872094540?pr=494

Also, is anyone familiar why benchmarks that are linked to shared libraries
may fail with Exit code 0xc0000135?
https://github.com/darktable-org/rawspeed/actions/runs/5428151349/jobs/9872096202?pr=494