Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Missing \n at the End of Console Output #1699

Closed
itzmeanjan opened this issue Nov 11, 2023 · 2 comments · Fixed by #1700
Closed

[BUG] Missing \n at the End of Console Output #1699

itzmeanjan opened this issue Nov 11, 2023 · 2 comments · Fixed by #1700
Labels
good first issue help wanted

Comments

@itzmeanjan
Copy link
Contributor

👋

It looks like we're missing a \n at the end of this message.

benchmark/src/perf_counters.cc

Line 257 in 159eb2d

GetErrorLogInstance() << "Performance counters not supported.";

Without \n, output looks like 👇.

Screenshot from 2023-11-11 21-34-48

I discovered this issue while benchmarking with libPFM on a Raspberry Pi 4b, more @ https://github.com/itzmeanjan/kyber/blob/6f8dc9070abe8dfbe0a8e400151b061ff0ef4ad0/README.md?plain=1#L251.
@dmah42
Copy link
Member

dmah42 commented Nov 13, 2023

patches welcome! :)

itzmeanjan added a commit to itzmeanjan/google-benchmark that referenced this issue Nov 13, 2023
@itzmeanjan
Add missing \n character at end of error log string
42c5b57 
Closes google#1699

Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
@itzmeanjan itzmeanjan mentioned this issue Nov 13, 2023
Merged
@itzmeanjan
Copy link
Contributor Author

@dmah42 Sent PR #1700

dmah42 pushed a commit that referenced this issue Nov 13, 2023
@itzmeanjan
Add missing \n character at end of error log string (#1700)
93a96a2 
Closes #1699

Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Missing \n at the End of Error Log String itzmeanjan/google-benchmark
2 participants
@dmah42 @itzmeanjan