-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings for visual studio #202
Comments
i'm not sure what you've tried, but this is a good starting point: https://cognitivewaves.wordpress.com/cmake-and-visual-studio/ once you have a solution file, you can build as normal in VS. what are the symbols? it might be our code :) |
If you have unresolved symbols you probably need to add shlwapi.lib to your linker inputs. |
@BillyONeal Should the CMake be linking |
@EricWF: Don't know if it is possible to ask cmake to do that. See here: Line 36 in 6e25917
The dependency on |
(MSVC++ has |
Thanks Billy. I don't work on Windows so I'm trying to figure out if this is our bug, or just a general quirk of Windows compilation (like -pthread or -lm on Unix). If we ever get a CMake configuration module we should ensure I think the best course of action is to prominently document the dependency as a known issue and close this bug. |
@BillyONeal Patches correctly implementing |
@EricWF: You can just stick that pragma in sysinfo.cc, and that lib will be added as a dependency for anyone who links against the resulting .obj. Putting it after Line 19 in 95dee3c
|
@BillyONeal , can you explain to Nooglers who aren't used to using Cmake how I can manually link in Shlwapi into my projects CMakeLists? Edit: figured it out. Just added "shlwapi.lib" to target_link_library command in my project. (Do add an example line of code, as I went on a wild goose chase to find the physical location of that file not knowing minGW had it on its regular path) |
@winstondu In the same
|
These changes were necessary to compile on Windows with "-DARROW_BUILD_BENCHMARKS=ON". I added Shwlapi based on google/benchmark#202. Author: Adam Seibert <seibs@users.noreply.github.com> Closes #1406 from seibs/ARROW-1909 and squashes the following commits: 98602cd [Adam Seibert] ARROW-1909: [C++] Enables building with benchmarks on windows
Once i build the INSTALL.vcproj and RUN_TESTS , how do i link the library to a new VS project |
@Cxx-mlr I have the same requirement to link the library to a new VS project. Did you get it working yet? If yes, can you please share the steps to do it? |
If the benchmark project is generated with There is no need to specify I don't think that the version being installed through vcpkg is build with shared libs on - I had to build it specifically off a forked version. |
is there a way to change the vcpkg installer version to include shared libs? |
Hello, may i know how am i supposed to compile it with visual studio? throws unresolved external symbols, i believe your code is not wrong, it's probably because of the compiler.
The text was updated successfully, but these errors were encountered: