Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplified code #1439

Merged
merged 1 commit into from
Jul 21, 2022
Merged

simplified code #1439

merged 1 commit into from
Jul 21, 2022

Conversation

maochongxin
Copy link
Contributor

No description provided.

@dmah42
Copy link
Member

dmah42 commented Jul 21, 2022

i don't understand how this is simpler or better. can you add more details to why you think it's useful?

@maochongxin
Copy link
Contributor Author

i don't understand how this is simpler or better. can you add more details to why you think it's useful?

Thanks for reply, I think here, it is more appropriate to use the size() method directly than the size variable itself, the new size variable is more appropriate to represent the size of the new buffer.

@dmah42
Copy link
Member

dmah42 commented Jul 21, 2022

fair enough :) thanks!

@dmah42 dmah42 merged commit ef7f75f into google:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maochongxin @dmah42