Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clang Detection #697

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Fix Clang Detection #697

merged 1 commit into from
Oct 5, 2018

Conversation

Lord-Kamina
Copy link
Contributor

For several versions now, CMake by default refers to macOS’ Clang as AppleClang instead of just Clang, which would fail STREQUAL. Fixed by changing it to MATCHES.

For several versions now, CMake by default refers to macOS’ Clang as AppleClang instead of just Clang, which would fail STREQUAL. Fixed by changing it to MATCHES.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@Lord-Kamina
Copy link
Contributor Author

CLA signed.

@googlebot
Copy link

CLAs look good, thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.256% when pulling 6b764fe on Lord-Kamina:master into a8082de on google:master.

@AppVeyorBot
Copy link

@dmah42
Copy link
Member

dmah42 commented Oct 5, 2018

Thanks!

@dmah42 dmah42 merged commit 9ffb8df into google:master Oct 5, 2018
JBakamovic pushed a commit to JBakamovic/benchmark that referenced this pull request Dec 6, 2018
For several versions now, CMake by default refers to macOS’ Clang as AppleClang instead of just Clang, which would fail STREQUAL. Fixed by changing it to MATCHES.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants