Fix parsing of cpuinfo for s390 platform. #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s390 has another line structure for processor-field. It should be differently parsed.
|
✅ Build benchmark 1541 completed (commit 5d44fa5500 by @gladk) |
LebedevRI
reviewed
Oct 21, 2018
src/sysinfo.cc
Outdated
| @@ -404,7 +404,11 @@ int GetNumCPUs() { | |||
| if (ln.empty()) continue; | |||
| size_t SplitIdx = ln.find(':'); | |||
| std::string value; | |||
| #if defined(__s390__) | |||
| if (SplitIdx != std::string::npos) value = ln.substr(SplitIdx - 1, 2); | |||
There was a problem hiding this comment.
Does this put a limit on the length of cpu number?
|
@LebedevRI thanks for the valuable comment. I improved the line which extracts the processor number. Now it works for any number of CPUs. |
LebedevRI
approved these changes
Oct 21, 2018
|
✅ Build benchmark 1542 completed (commit 1e3ccc8991 by @gladk) |
EricWF
pushed a commit
to efcs/benchmark
that referenced
this pull request
Nov 29, 2018
s390 has another line structure for processor-field. It should be differently parsed.
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Dec 6, 2018
s390 has another line structure for processor-field. It should be differently parsed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s390 has another line structure for processor-field.
It should be differently parsed.
Should fix #711