Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Fix check for verilog parameters #22

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

antonblanchard
Copy link
Contributor

bigspicy always prints a warning that verilog modules have parameters,
even if they don't.

With this patch we correctly print the warning when there are parameters:

cat << EOF > test1.v
module test1 #(
    parameter FOO = 1
);
endmodule
EOF
./bigspicy.py --import --verilog test1.v --top test1

And don't print the warning when there are no parameters:

cat << EOF > test2.v
module test2 (
);
endmodule
EOF
./bigspicy.py --import --verilog test2.v --top test2

bigspicy always prints a warning that verilog modules have parameters,
even if they don't.
@google-cla
Copy link

google-cla bot commented Sep 6, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@antonblanchard
Copy link
Contributor Author

Looking into the CLA issue

@growly
Copy link
Contributor

growly commented Sep 6, 2022

Thans Anton. Are you able/willing to sign the CLA? If not I can make the same patch.

@growly growly merged commit d6bdc61 into google:main Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants