Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update block info when dropdown field matches search query #2013

Closed
wants to merge 1 commit into from

Conversation

ludizhan
Copy link

@ludizhan ludizhan commented Oct 7, 2023

The basics

The details

Resolves

Fixes #1940

Part 1 change to index the dropdown field merged: #1971
This is the part 2 change.

Proposed Changes

Updating the BlockInfo in flyoutItems_ with additional fields information, when a dropdown field includes with the search query.

Reason for Changes

Without the change currently when searching a dropdown field, the default is selected even though search query is matching a different dropdown option.

Test Coverage

Tested manually.

FYI the toolbox search feature on osd branch is broken in local for me, so I tested the change on master branch:

Before (with only the part 1 change #1971):
Screenshot 2023-10-06 at 6 16 02 PM

After:
Screenshot 2023-10-06 at 6 17 16 PM

Documentation

No documentation impact.

Additional Information

There is a similar PR for master branch that addresses the same issue: #2004
Either one should work..

@ludizhan ludizhan requested a review from a team as a code owner October 7, 2023 01:18
@ludizhan ludizhan requested review from maribethb and removed request for a team October 7, 2023 01:18
@ludizhan ludizhan mentioned this pull request Oct 7, 2023
1 task
@ludizhan
Copy link
Author

Hi @maribethb @BeksOmega can you help approve running the workflow?

@ludizhan
Copy link
Author

Fixed the lint error and double checked that there's no additional error for npm run lint.

@BeksOmega BeksOmega assigned BeksOmega and unassigned maribethb Oct 30, 2023
@BeksOmega BeksOmega requested review from BeksOmega and removed request for maribethb October 30, 2023 22:20
@BeksOmega
Copy link
Contributor

Heya @ludizhan ! Sorry someone didn't get back to you sooner :/ Are you still interested in working on this? We recentlymerged the osd branch, so this will need to be rebased against master to go in.

@BeksOmega
Copy link
Contributor

@ludizhan I'm going to go ahead and close this as stale =) But if you're still interested in working on it just let me know!

@BeksOmega BeksOmega closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants