feat: update block info when dropdown field matches search query #2013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #1940
Part 1 change to index the dropdown field merged: #1971
This is the part 2 change.
Proposed Changes
Updating the
BlockInfo
inflyoutItems_
with additionalfields
information, when a dropdown field includes with the search query.Reason for Changes
Without the change currently when searching a dropdown field, the default is selected even though search query is matching a different dropdown option.
Test Coverage
Tested manually.
FYI the toolbox search feature on osd branch is broken in local for me, so I tested the change on master branch:
Before (with only the part 1 change #1971):
![Screenshot 2023-10-06 at 6 16 02 PM](https://private-user-images.githubusercontent.com/61517522/273354490-48450844-924b-48e6-8143-98fc49dd503d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MjUyNDMsIm5iZiI6MTcxOTQyNDk0MywicGF0aCI6Ii82MTUxNzUyMi8yNzMzNTQ0OTAtNDg0NTA4NDQtOTI0Yi00OGU2LTgxNDMtOThmYzQ5ZGQ1MDNkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDE4MDIyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNjNWFmY2NlZjY4M2NjNWFhMjFhNDY2MThlZTg4MDVmZjE3N2JhYTc3NTA2Y2M4NTQ1NTZkMDFhODhiYzAxNWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Y30kRF-q0AiHN_psWPnkcfsTxBBoF2BTAZSXpsEeCC0)
After:
![Screenshot 2023-10-06 at 6 17 16 PM](https://private-user-images.githubusercontent.com/61517522/273354509-8a930d61-5205-49a5-9df0-9f38e1effd79.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MjUyNDMsIm5iZiI6MTcxOTQyNDk0MywicGF0aCI6Ii82MTUxNzUyMi8yNzMzNTQ1MDktOGE5MzBkNjEtNTIwNS00OWE1LTlkZjAtOWYzOGUxZWZmZDc5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDE4MDIyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcyOWIxMjhkN2U0MjI4YTZhYjQ3NjdjMDZkMzAwNjk5ZmE2Mjc2MDJlOWZhODVmZTExNGUyYTE4ZTFmNzk0NzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.7_UudFWCjaVyqS6RSgyRjNtbylG8lenZ0ANgWDKUCcw)
Documentation
No documentation impact.
Additional Information
There is a similar PR for master branch that addresses the same issue: #2004
Either one should work..