-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Index dropdown field option for toolbox-search #1971
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I faced a similar linting issue. You can try |
fix instead of Fix |
@humera811 @sammitako There are 3 commits in this PR, the issue is probably caused by the other commits in the PR. Can you try this?
|
Note: This actually partially fixes #1940 There were 2 steps stated in the original issue about how to fix it, and this completes and first step. We intend to follow up with another PR later to complete the second step, as well as adding unit tests. |
Thanks for the hard work everyone! I look forward to part 2 of this issue! |
The basics
The details
Resolves
Partially addresses
#1940
Proposed Changes
When indexing blocks, check if a field is a dropdown, and index the text value and ImageProperties value of their options.
Reason for Changes
When the block has a dropdown option, other than the default one, the hidden values in the options are not searchable.
Test Coverage
Manually test only.
Documentation
No.
Additional Information
Collaborated with https://github.com/ludizhan