Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Index dropdown field option for toolbox-search #1971

Merged
merged 3 commits into from
Sep 23, 2023

Conversation

sammitako
Copy link
Contributor

@sammitako sammitako commented Sep 22, 2023

The basics

The details

Resolves

Partially addresses
#1940

Proposed Changes

When indexing blocks, check if a field is a dropdown, and index the text value and ImageProperties value of their options.

Reason for Changes

When the block has a dropdown option, other than the default one, the hidden values in the options are not searchable.

Test Coverage

Manually test only.

Documentation

No.

Additional Information

Collaborated with https://github.com/ludizhan

@sammitako sammitako requested a review from a team as a code owner September 22, 2023 23:56
@sammitako sammitako requested review from johnnesky and removed request for a team September 22, 2023 23:56
@google-cla
Copy link

google-cla bot commented Sep 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@humera811
Copy link
Contributor

humera811 commented Sep 23, 2023

I faced a similar linting issue. You can try
git commit --amend -m "fix: Update toolbox-search to search dropdown field options"
git push --force origin osd

@humera811
Copy link
Contributor

I faced a similar linting issue. You can try git commit --amend -m "fix: Update toolbox-search to search dropdown field options" git push --force origin osd

fix instead of Fix

@ludizhan
Copy link

@humera811 @sammitako There are 3 commits in this PR, the issue is probably caused by the other commits in the PR.

Can you try this?

  • git rebase -i HEAD~3 Enter interactive rebase mode for the 3 most recent commits
  • Replace pick with reword for the commit that doesn't start with fix: or feat:
    • Basically replace the first line pick f5822adf Index dropdown field option for toolbox-search -> reword f5822adf Index dropdown field option for toolbox-search
    • The allows you to update the commit message
  • Modify the commit message to fix: Index dropdown field option for toolbox-search
  • After saving, you should exit the interactive rebase mode
  • git push --force origin osd

@ludizhan
Copy link

Note: This actually partially fixes #1940

There were 2 steps stated in the original issue about how to fix it, and this completes and first step.

We intend to follow up with another PR later to complete the second step, as well as adding unit tests.

@johnnesky johnnesky changed the title Index dropdown field option for toolbox-search feat: Index dropdown field option for toolbox-search Sep 23, 2023
@johnnesky
Copy link
Member

Thanks for the hard work everyone! I look forward to part 2 of this issue!

@johnnesky johnnesky merged commit 036f238 into google:osd Sep 23, 2023
7 checks passed
@BeksOmega BeksOmega linked an issue Sep 29, 2023 that may be closed by this pull request
1 task
@BeksOmega BeksOmega mentioned this pull request Oct 4, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update toolbox-search to search dropdown field options
4 participants