text_join argument precedence bug in PHP #2161
Labels
component: generators
help wanted
External contributions actively solicited
issue: bug
Describes why the code or behaviour is wrong
low priority
Problem statement
The
text_join
block uses incorrect argument precedence in PHP code generation.Steps to Reproduce
Toggle
true
tofalse
at the next run.Actual Behavior
It produces 'T' or 'FX', based on the test value.
Expected Behavior
Return 'TX' or 'FX' respectively.
Additional Information
if (block.itemCount_ == 2)
, it usesBlockly.PHP.ORDER_NONE
for its arguments instead of something smaller.And should return
[code, Blockly.PHP.ORDER_STRING_CONCAT]
(which level is actually never used in the code base) instead ofORDER_ADDITION
.The text was updated successfully, but these errors were encountered: