Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2161: Changes outerOrder for PHP/text component. #2179

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

DubeySandeep
Copy link
Contributor

@DubeySandeep DubeySandeep commented Dec 17, 2018

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Fixes #2161.

Proposed Changes

  • image
    • PHP code generated: 'B' . 'C';
    • Earlier: 'B' . 'C';
  • image
    • PHP code generated: (true ? 'A' : 'B') . 'C';
    • Earlier: true ? 'A' : 'B' . 'C';
  • image
    • PHP code generated: 'C' . (true ? 'A' : 'B');
    • Earlier: 'C' . true ? 'A' : 'B';
  • image
    • PHP code generated: (true ? 'A' : 'B') . (true ? 'C' : 'D');
    • Earlier: true ? 'A' : 'B' . true ? 'C' : 'D';

Reason for Changes

This changes will make text block for 2 endpoints generate correct code.

Test Coverage

Steps followed while testing these changes:

  • Created a text block.
  • Added logic block in the first plug.
  • Added text in 2nd plug.
  • Check PHP code.
  • Add more endpoints for the text blocks and follow the above steps.

Also, did unit tests as suggested here.

Tested on:

  • Desktop Chrome
  • Desktop Firefox

@rachel-fenichel
Copy link
Collaborator

LGTM

@rachel-fenichel rachel-fenichel merged commit e469090 into google:develop Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants