Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlocklyFactory: Remove dependency on closure. #668

Closed
picklesrus opened this issue Oct 4, 2016 · 1 comment
Closed

BlocklyFactory: Remove dependency on closure. #668

picklesrus opened this issue Oct 4, 2016 · 1 comment
Labels
component: devtools type: cleanup

Comments

@picklesrus
Copy link
Contributor

The main ones to remove are goog.dom.xml and goog.ui.PopupColorPicker.

Once that's done, remove the message in app_controller's init.
picklesrus added a commit to picklesrus/blockly that referenced this issue Oct 4, 2016
@picklesrus
Add warning if you do not have required parts of closure available wh…
51bf25e 
…en loading BlocklyFactory. This should be temporary until google#668 is fixed
@picklesrus picklesrus mentioned this issue Oct 4, 2016
Merged
picklesrus added a commit that referenced this issue Oct 4, 2016
@picklesrus
Add warning if you do not have required parts of closure available wh…
70a8bcd 
…en loading BlocklyFactory. This should be temporary until #668 is fixed (#669)
@picklesrus picklesrus mentioned this issue Oct 4, 2016
Closed
@NeilFraser NeilFraser mentioned this issue Apr 26, 2017
Merged
@rachel-fenichel rachel-fenichel mentioned this issue May 1, 2017
Closed
@AnmAtAnm AnmAtAnm self-assigned this Jun 15, 2018
@AnmAtAnm AnmAtAnm mentioned this issue Jun 15, 2018
Closed
@AnmAtAnm AnmAtAnm mentioned this issue Jun 15, 2018
Merged
3 tasks
@AnmAtAnm AnmAtAnm mentioned this issue Jun 25, 2018
Open
NeilFraser added a commit that referenced this issue Jun 13, 2019
@NeilFraser
Remove last Closure from Block Factory.
61d6477 
Improves UI, but is still pretty clunky.  For example there’s still not way to choose “no colour”.
Closes #668.
@NeilFraser NeilFraser mentioned this issue Jun 13, 2019
Merged
NeilFraser added a commit that referenced this issue Jun 26, 2019
@NeilFraser
Remove last Closure from Block Factory.
7e048f2 
Improves UI, but is still pretty clunky.  For example there’s still not way to choose “no colour”.
Closes #668.
@NeilFraser
Copy link
Contributor

Fixed.

@rachel-fenichel rachel-fenichel mentioned this issue Jul 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: devtools type: cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NeilFraser @AnmAtAnm @picklesrus